Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support clipboard context on variable copy operation #917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zobo
Copy link
Contributor

@zobo zobo commented Jul 22, 2023

When the IDE requests evaluation with clipboard context use var_export to format the response

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #917 (1773ad8) into main (4df70ce) will increase coverage by 0.27%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   67.00%   67.28%   +0.27%     
==========================================
  Files          14       14              
  Lines        1982     2005      +23     
  Branches      389      395       +6     
==========================================
+ Hits         1328     1349      +21     
- Misses        654      656       +2     
Impacted Files Coverage Δ
src/xdebugConnection.ts 82.03% <86.66%> (+0.17%) ⬆️
src/phpDebug.ts 62.93% <100.00%> (+0.41%) ⬆️

@zobo
Copy link
Contributor Author

zobo commented Jul 24, 2023

Using eval here causes issues, for example, when accessing private properties. Also it does not have support for stack depth. https://bugs.xdebug.org/view.php?id=1342
A correct implementation would be to implement var_export in JS and fetch data via property_get/property_value

@zobo zobo mentioned this pull request Nov 7, 2023
2 tasks
@eduwass
Copy link

eduwass commented May 28, 2024

I'd love to see this implemented. 👀

@zobo zobo mentioned this pull request Jul 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add advanced copy variable values
2 participants